[lldb] Do not use DomainSocket on Windows #137415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buildbot lldb-remote-linux-win is broken after llvm#136466. This patch should make it green.
Member
|
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesThe buildbot lldb-remote-linux-win is broken after #136466. This patch should make it green. Full diff: https://github.com/llvm/llvm-project/pull/137415.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-server/lldb-platform.cpp b/lldb/tools/lldb-server/lldb-platform.cpp
index b9a85370d649c..10d79c63af994 100644
--- a/lldb/tools/lldb-server/lldb-platform.cpp
+++ b/lldb/tools/lldb-server/lldb-platform.cpp
@@ -469,6 +469,7 @@ int main_platform(int argc, char *argv[]) {
if (gdbserver_port) {
socket = std::make_unique<TCPSocket>(sockfd, /*should_close=*/true);
} else {
+#if LLDB_ENABLE_POSIX
llvm::Expected<std::unique_ptr<DomainSocket>> domain_socket =
DomainSocket::FromBoundNativeSocket(sockfd, /*should_close=*/true);
if (!domain_socket) {
@@ -477,6 +478,11 @@ int main_platform(int argc, char *argv[]) {
return socket_error;
}
socket = std::move(domain_socket.get());
+#else
+ WithColor::error() << "lldb-platform child: Unix domain sockets are not "
+ "supported on this platform.";
+ return socket_error;
+#endif
}
GDBRemoteCommunicationServerPlatform platform(socket->GetSocketProtocol(),
|
Contributor
Author
|
Duplicate of #137414. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildbot lldb-remote-linux-win is broken after #136466. This patch should make it green.